New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(): Disable offscreen check for bg and overlay when not needed #8898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Stats
|
ShaMan123
reviewed
May 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you should fine tune tests and put in the description this regards only rendering
I see how the necessity of adding canvas to backgroundImage ( or overlay ) is unhandled. Tests do catch regression |
ShaMan123
previously approved these changes
May 8, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
closes #8887
the setting to make bg and overlay independent from zoom and panning are not respected by isOffscreen.
There isn't an easy way to solve this, and this one line fix is probably a way to block the bug for now.
We could have pulled the onscreen check outside of the render function but that could have unintended consequences on existing subclasses and also share the responsibility of offscreen check to more players ( canvas and group at least ).
Changes
The function to render backround or overlay will disable the offscreen check if needed and restore it later
Gist
In Action