-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TS) export filter types #8913
Conversation
Build Stats
|
export { BaseBrush } from './src/brushes/BaseBrush'; | ||
export * from './src/brushes/typedefs'; | ||
|
||
export { PencilBrush } from './src/brushes/PencilBrush'; | ||
export { CircleBrush } from './src/brushes/CircleBrush'; | ||
export { SprayBrush } from './src/brushes/SprayBrush'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is the decision regarding index files?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it doesn't make my life simpler i don't add one.
in this case i could write a line to export types and i did.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think i can see a typedef file as the index file of the types alone.
Since i try to differentiate types from code exports, in this case a file alone serve the purpose well
Motivation
More type exporting