-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(TS): minor style #8941
chore(TS): minor style #8941
Conversation
Build Stats
|
@@ -8,7 +8,7 @@ const fontProperties = [ | |||
'fontStyle', | |||
] as const; | |||
|
|||
const textDecorationProperties = [ | |||
export const textDecorationProperties = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need to export this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think maybe is a leftover of trying to get the type automatically from this array?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something like that
I used it for the HTML logic
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do you need export it or not? i can't find this used anywhere
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really
I added the changelog manually here because for some reason the action can't add it here. |
Motivation
Improve some typings
Description
Changes
Gist
In Action