-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(): invoke tests after changelog action #8974
Conversation
Build Stats
|
Well it didn't work so I am going for the second option |
This reverts commit 9280b48.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DONE
I think in general if we reduce the amount of tests/checks we run is better, especially the CI infrastructure is free until people abuse it. |
I agree, that is why I added the ignore paths but the UI is so annoying. Once the changelog action commits, the tests are skipped and the UI doesn't show the previous run.
We have this already in .gitattributes |
I don't mind reverting this |
This reverts commit d5a9553.
Motivation
Since I have disabled tests when a change is made to the changelog they don't show up in the PR UI after the changelog finishes and it is vital they do.It is used for one commit PRs because if you continue pushing then tests will start and everything is fine. There are other options I have been using (closing and re-opening a PR and I think I can invoke manually but it is annoying)
We could simply remove the
ignore-paths
directive instead of what I did in this PR.Whatever you decide is good for me.
It didn't work so I removed
paths-ignore
Description
Changes
Gist
In Action