-
-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs() enable typedocs to run again #9356
Conversation
Build Stats
|
…o run-typedoc-again
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can't it ignore *.test.ts
*.spec.ts
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about an action for a PR merge to push to the website?
Then we see it actually runs and the website is kept to date
I tried of course, it doesn't work. |
When it works it can be done, for now it doesn't work at all, the pages are ugly, creating a custom theme for mark down is not very well documented ( or docs are hard to find ) and gatsby adds its own issues with mdx and ts syntax overlap. |
probably we should add a step that run the docs and that we check ti can run at least. So we can detect breakage waiting for the time that we can dig into why excluding doesn't really work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed the config, it skips the excluded files now - tested in a branch w/o the fixes from this branch
Motivation
typedoc does not run anymore.
It complains of some code inside tests.
I changed the code of tests and jest extend and removed the protected from toObject.