chore(): expose sendVectorToPlane
#9479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Stats
|
…c.js into sendVectorToPlane
ShaMan123
commented
Nov 4, 2023
Comment on lines
+19
to
+32
| describe('Plane Change', () => { | ||
| test('calcPlaneChangeMatrix', () => { | ||
| const m1: TMat2D = [1, 2, 3, 4, 5, 6]; | ||
| const s: TMat2D = [2, 0, 0, 0.5, 0, 0]; | ||
| expect(calcPlaneChangeMatrix()).toEqual(iMatrix); | ||
| expect(calcPlaneChangeMatrix(undefined, m1)).toEqual(invertTransform(m1)); | ||
| expect(calcPlaneChangeMatrix(iMatrix, m1)).toEqual(invertTransform(m1)); | ||
| expect(calcPlaneChangeMatrix(m1, undefined)).toEqual(m1); | ||
| expect(calcPlaneChangeMatrix(m1, iMatrix)).toEqual(m1); | ||
| expect(calcPlaneChangeMatrix(m1, m1)).toEqual(iMatrix); | ||
| expect(calcPlaneChangeMatrix(m1, s)).toEqual( | ||
| multiplyTransformMatrices(invertTransform(s), m1) | ||
| ); | ||
| }); |
There was a problem hiding this comment.
migrate from qunit
Comment on lines
+34
to
+56
| test('sendPointToPlane', () => { | ||
| const s: TMat2D = [2, 0, 0, 0.5, 50, 50]; | ||
| const point = new Point(1, 1); | ||
| expect(sendPointToPlane(point, s)).toEqual({ x: 52, y: 50.5 }); | ||
| expect(sendPointToPlane(point, undefined, s)).toEqual({ x: -24.5, y: -98 }); | ||
| expect( | ||
| sendPointToPlane(point, createRotateMatrix({ angle: 90 }), s) | ||
| ).toEqual({ x: -25.5, y: -98 }); | ||
| expect(sendPointToPlane(point, s, s)).toEqual(point); | ||
| expect(sendPointToPlane(point)).toEqual(point); | ||
| }); | ||
|
|
||
| test('sendVectorToPlane', () => { | ||
| const s: TMat2D = [2, 0, 0, 0.5, 50, 50]; | ||
| const point = new Point(1, 1); | ||
| expect(sendVectorToPlane(point, s)).toEqual({ x: 2, y: 0.5 }); | ||
| expect(sendVectorToPlane(point, undefined, s)).toEqual({ x: 0.5, y: 2 }); | ||
| expect( | ||
| sendVectorToPlane(point, createRotateMatrix({ angle: 90 }), s) | ||
| ).toEqual({ x: -0.5, y: 2 }); | ||
| expect(sendVectorToPlane(point, s, s)).toEqual(point); | ||
| expect(sendVectorToPlane(point)).toEqual(point); | ||
| }); |
Comment on lines
+58
to
+91
| test('sendObjectToPlane', () => { | ||
| const m: TMat2D = [6, Math.SQRT1_2, 0, 3, 2, 1]; | ||
| const m1: TMat2D = [3, 0, 0, 2, 10, 4]; | ||
| const m2: TMat2D = [1, Math.SQRT1_2, Math.SQRT1_2, 4, 5, 6]; | ||
| const group = new Group(); | ||
| const group2 = new Group(); | ||
| const obj = new FabricObject(); | ||
|
|
||
| jest.spyOn(group, 'isOnACache').mockReturnValue(false); | ||
|
|
||
| applyTransformToObject(obj, m); | ||
| applyTransformToObject(group, m1); | ||
| applyTransformToObject(group2, m2); | ||
|
|
||
| obj.group = group; | ||
| const actual = sendObjectToPlane( | ||
| obj, | ||
| group.calcTransformMatrix(), | ||
| group2.calcTransformMatrix() | ||
| ); | ||
| expect(actual).toEqualRoundedMatrix( | ||
| multiplyTransformMatrices( | ||
| invertTransform(group2.calcTransformMatrix()), | ||
| group.calcTransformMatrix() | ||
| ) | ||
| ); | ||
| expect(obj.calcOwnMatrix()).toEqualRoundedMatrix( | ||
| multiplyTransformMatrices(actual, m) | ||
| ); | ||
|
|
||
| obj.group = group2; | ||
| expect(obj.calcTransformMatrix()).toEqualRoundedMatrix( | ||
| multiplyTransformMatrices( | ||
| multiplyTransformMatrices(group2.calcTransformMatrix(), actual), |
There was a problem hiding this comment.
migrated from qunit
asturur
previously approved these changes
Nov 6, 2023
asturur
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
send plane utils are proving to be valuble
send a vector is also very common and completes the util
Description
expose
sendVectorToPlanemigrate send plane tests to jest, removing the
sendPointToPlaneold test that was unnecessaryChanges
Gist
In Action