Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Major inconsistency in mappings resolver API #107

Closed
Pyrofab opened this issue Apr 22, 2019 · 1 comment
Closed

Major inconsistency in mappings resolver API #107

Pyrofab opened this issue Apr 22, 2019 · 1 comment

Comments

@Pyrofab
Copy link
Contributor

Pyrofab commented Apr 22, 2019

All map methods in FabricMappingResolver require class names in dot format, but nothing is actually done to convert dot format to internal anywhere. As such, no mapping can ever get resolved.
@asiekierka
Copy link
Contributor

I wonder who could be behind this unfortunate mistake! 🤔

Chocohead added a commit to Chocohead/Fabric-ASM that referenced this issue Sep 30, 2019
@Chocohead
Expand enum tests
086fb46 
Aims to catch more edge case situations with different stack states
Bumps Fabric Loader version to account for MappingResolver being broken (FabricMC/fabric-loader#107)
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@asiekierka @Pyrofab