OpenVZ tools don't work anymore

[frankrousseau]

Hi ronnix,

Since the Fabric 1.5.0 release, Fabtools OpenVZ commands don't work anymore. It complains about not finding the quiet import from fabric.api . I'm ok to make a pull request for that but I don't know where to start. Could you point me what to do to solve this problem ?

Whatever thanks for fabtools which helps us a lot.

Frank

[ronnix]

Thanks for opening an issue. I haven't taken the time to really look into it yet, so it's good to have a reminder. Can you copy the complete error message?

[frankrousseau]

That's not an import error, but an argument error sorry:

Traceback (most recent call last):
  File "/usr/local/lib/python2.7/dist-packages/fabric/main.py", line 739, in main
    *args, **kwargs
  File "/usr/local/lib/python2.7/dist-packages/fabric/tasks.py", line 316, in execute
    multiprocessing
  File "/usr/local/lib/python2.7/dist-packages/fabric/tasks.py", line 213, in _execute
    return task.run(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/fabric/tasks.py", line 123, in run
    return self.wrapped(*args, **kwargs)
  File "/home/frankrousseau/.../fabfile.py", line 12, in deploy_prod
    run("cd /... && git checkout master")
  File "/usr/local/lib/python2.7/dist-packages/fabric/network.py", line 535, in host_prompting_wrapper
    return func(*args, **kwargs)
  File "/usr/local/lib/python2.7/dist-packages/fabric/operations.py", line 1017, in run
    warn_only=warn_only, stdout=stdout, stderr=stderr, timeout=timeout)
TypeError: run_guest_command() got an unexpected keyword argument 'quiet'

[ronnix]

Thanks! The OpenVZ guest context manager is a big hack, that monkey patches fabric's run function. The API must have changed, so the run_guest_command in fabtools/openvz/contextmanager.py will have to be updated. We may also have to bump the fabric version dependency in setup.py if the API is different in 1.5.x and 1.6.x.

[ronnix]

This should work now. I successfully ran the functional tests on a Debian Squeeze box with the OpenVZ kernel.

[frankrousseau]

Wow thank you Ronnix ! By the way I will give a talk at Solution Linux about fast web development : fabtools inside.

[ronnix]

Great, thanks!