-
-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a sample for an editable TreeView #239
Conversation
to speed up testing
to speed up testing
but I don't quite understand why - what's there to learn here?
because referencing nested types in xaml styles doesn't seem to work for some reason
@edgarfgp Thanks for the new model to try out and taking the time to answer! I've rebased on your changes, added your suggestion, applied some fixes and tested. Sadly, it's not quite working as it should. I suspect two major issues:
You'll find my detailed feedback and some code helping to showcase the nesting in the latest commit. |
except for when hitting a breakpoint during debugging
Co-authored-by: Edgar Gonzalez <edgargonzalez.info@gmail.com>
… to Application.MainWindow in Debug config see https://docs.avaloniaui.net/docs/guides/implementation-guides/developer-tools solving fabulous-dev#118
Yeah I thought Avalonia itself will manage the TreeViewItem.IsExpanded but seems like we are forced to use
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating this sample. I would be ok merging this as the sample has improved and also the attachDevTools are handy.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edgarfgp Thanks for fixing the parameter name/doco mismatch and replacing Option
with ValueOption
- the latter was new to me.
@edgarfgp Thank you for your time and effort! I'll clean the unnecessary code from the new sample in a separate PR. |
In this PR I'm trying to raise a few questions and issues I encountered while working with the
TreeView
andAutoCompleteBox
widgets.It adds a third tab hosting a sample of an editable
TreeView
to theGallery
app'sTreeViewPage
that features adding, removing, renaming and filtering items while preserving tree node expansion. While I got that working, the solution involves a XAML style with a Binding that I don't like much.As a follow-up to #231, it includes a working example of focusing an added
TextBox
- but trying the same on anAutoCompleteBox
doesn't seem to work unless hitting a magic breakpoint during debugging. See commit changing input to AutoCompleteBox, breaking focus.Note that it includes commits that run the
EditableTreeView
from thePlayground
app built only for dotnet for quicker testing - because building the Gallery takes a while. Those changes are reverted in the last commit.You should be able to check out different commits to reproduce the different stages of broken and working features as described in the commit messages.
Please find my open questions in the commit added open questions.
Thank you for your time and consideration 🙏