Merge pull request #40 from fabulous-dev/missing-modifiers

Added missing Cell.ContextActions and MultiPage.CurrentPage modifiers

CHANGELOG.md

@@ -9,6 +9,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 No unreleased changes.
 
+## [2.4.2] - 2023-12-07
+
+### Added
+- Added missing Cell.ContextActions and MultiPage.CurrentPage modifiers (https://github.com/fabulous-dev/Fabulous.XamarinForms/pull/40)
+
 ## [2.4.1] - 2023-11-26
 
 ### Added
@@ -56,7 +61,8 @@ No unreleased changes.
 ### Changed
 - Fabulous.XamarinForms has moved from the Fabulous repository to its own repository: [https://github.com/fabulous-dev/Fabulous.XamarinForms](https://github.com/fabulous-dev/Fabulous.XamarinForms)
 
-[unreleased]: https://github.com/fabulous-dev/Fabulous.XamarinForms/compare/2.4.1...HEAD
+[unreleased]: https://github.com/fabulous-dev/Fabulous.XamarinForms/compare/2.4.2...HEAD
+[2.4.2]: https://github.com/fabulous-dev/Fabulous.XamarinForms/releases/tag/2.4.2
 [2.4.1]: https://github.com/fabulous-dev/Fabulous.XamarinForms/releases/tag/2.4.1
 [2.4.0]: https://github.com/fabulous-dev/Fabulous.XamarinForms/releases/tag/2.4.0
 [2.3.0]: https://github.com/fabulous-dev/Fabulous.XamarinForms/releases/tag/2.3.0

src/Fabulous.XamarinForms/CollectionBuilderExtensions.fs

@@ -86,6 +86,13 @@ type CollectionBuilderExtensions =
         ) : Content<'msg> =
         { Widgets = MutStackArray1.One(x.Compile()) }
 
+    [<Extension>]
+    static member inline Yield<'msg, 'marker, 'itemType when 'marker :> ICell and 'itemType :> IMenuItem>
+        (
+            _: AttributeCollectionBuilder<'msg, 'marker, IMenuItem>,
+            x: WidgetBuilder<'msg, 'itemType>
+        ) : Content<'msg> =
+        { Widgets = MutStackArray1.One(x.Compile()) }
 
     [<Extension>]
     static member inline Yield<'msg, 'marker, 'itemType when 'itemType :> IPage>

src/Fabulous.XamarinForms/Views/Cells/_Cell.fs

@@ -30,6 +30,9 @@ module Cell =
     let Tapped =
         Attributes.defineEventNoArg "Cell_Tapped" (fun target -> (target :?> Cell).Tapped)
 
+    let ContextActions =
+        Attributes.defineListWidgetCollection "Cell_ContextActions" (fun target -> (target :?> Cell).ContextActions)
+
 [<Extension>]
 type CellModifiers =
 
@@ -56,3 +59,7 @@ type CellModifiers =
     [<Extension>]
     static member inline onTapped(this: WidgetBuilder<'msg, #ICell>, onTapped: 'msg) =
         this.AddScalar(Cell.Tapped.WithValue(MsgValue onTapped))
+
+    [<Extension>]
+    static member inline contextActions<'msg, 'marker when 'marker :> ICell>(this: WidgetBuilder<'msg, 'marker>) =
+        WidgetHelpers.buildAttributeCollection<'msg, 'marker, IMenuItem> Cell.ContextActions this

src/Fabulous.XamarinForms/Views/Pages/_MultiPageOfPage.fs

@@ -1,6 +1,8 @@
 namespace Fabulous.XamarinForms
 
+open System
 open Fabulous
+open Fabulous.ScalarAttributeDefinitions
 open Xamarin.Forms
 open System.Runtime.CompilerServices
 
@@ -11,13 +13,65 @@ module MultiPageOfPage =
     let Children =
         Attributes.defineListWidgetCollection "MultiPageOfPage" (fun target -> (target :?> MultiPage<Page>).Children)
 
+    [<Obsolete("Use CurrentPageWithEvent instead")>]
     let CurrentPageChanged =
         Attributes.defineEventNoArg "MultiPageOfPage_CurrentPageChanged" (fun target -> (target :?> MultiPage<Page>).CurrentPageChanged)
 
+    let CurrentPageWithEvent =
+        let name = "MultiPageOfPage_CurrentPageWithEvent"
+
+        let key =
+            SimpleScalarAttributeDefinition.CreateAttributeData(
+                ScalarAttributeComparers.noCompare,
+                (fun oldValueOpt (newValueOpt: ValueEventData<int, int> voption) node ->
+                    let target = node.Target :?> MultiPage<Page>
+                    let event = target.CurrentPageChanged
+
+                    match newValueOpt with
+                    | ValueNone ->
+                        // The attribute is no longer applied, so we clean up the event
+                        match node.TryGetHandler(name) with
+                        | ValueNone -> ()
+                        | ValueSome handler -> event.RemoveHandler(handler)
+
+                        // Only clear the property if a value was set before
+                        match oldValueOpt with
+                        | ValueNone -> ()
+                        | ValueSome _ -> target.CurrentPage <- target.Children.[0]
+
+                    | ValueSome curr ->
+                        // Clean up the old event handler if any
+                        match node.TryGetHandler(name) with
+                        | ValueNone -> ()
+                        | ValueSome handler -> event.RemoveHandler(handler)
+
+                        // Set the new value
+                        target.CurrentPage <- target.Children.[curr.Value]
+
+                        // Set the new event handler
+                        let handler =
+                            EventHandler(fun sender args ->
+                                let multiPage = sender :?> MultiPage<Page>
+                                let currentPageIndex = multiPage.Children.IndexOf(multiPage.CurrentPage)
+                                let (MsgValue r) = curr.Event currentPageIndex
+                                Dispatcher.dispatch node r)
+
+                        node.SetHandler(name, ValueSome handler)
+                        event.AddHandler(handler))
+            )
+            |> AttributeDefinitionStore.registerScalar
+
+        { Key = key; Name = name }: SimpleScalarAttributeDefinition<ValueEventData<int, int>>
+
+
 [<Extension>]
 type MultiPageOfPageModifiers =
     /// <summary>Raised when the CurrentPage property changes.</summary>
     /// <param name="onCurrentPageChanged">The msg to invoke when the CurrentPage property changes.</param>
     [<Extension>]
     static member inline onCurrentPageChanged(this: WidgetBuilder<'msg, #IMultiPageOfPage>, onCurrentPageChanged: 'msg) =
         this.AddScalar(MultiPageOfPage.CurrentPageChanged.WithValue(MsgValue onCurrentPageChanged))
+
+    [<Extension>]
+    static member inline currentPage(this: WidgetBuilder<'msg, #IMultiPageOfPage>, currentPage: int, onCurrentPageChanged: int -> 'msg) =
+        this.AddScalar(MultiPageOfPage.CurrentPageWithEvent.WithValue(ValueEventData.create currentPage onCurrentPageChanged))