Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login & Sign up #1

Closed
7 tasks done
rebecacalvoquintero opened this issue Sep 28, 2017 · 0 comments
Closed
7 tasks done

Login & Sign up #1

rebecacalvoquintero opened this issue Sep 28, 2017 · 0 comments
Assignees
@rebecacalvoquintero @Jen-Harris
Labels
awaiting-review priority-2 T1d T4h
Milestone
Milestone 1

Comments

@rebecacalvoquintero
Copy link
Collaborator

rebecacalvoquintero commented Sep 28, 2017 •
edited
Loading

Sign Up

HBS

  • Create HTML for basic form structure

Controllors

  • Password module
  • Signup.js
  • signuppost.js

Database

  • signup.js

Validation

  • Includes Validation in backend
  • [x ] renders error messages on page
  • [x ] It should be secure enough --> nobody should be able to access to the database

Testing

  • Test all validation logic
@Jen-Harris Jen-Harris added this to the Milestone 1 milestone Sep 28, 2017
Jen-Harris added a commit that referenced this issue Sep 29, 2017
@Jen-Harris
#1 added passwordmodul.js
cfe123b
rebecacalvoquintero added a commit that referenced this issue Sep 29, 2017
@rebecacalvoquintero
#1 created validator.js, checks email, password, confirmpassword for …
b3168dc 
…signing up and loggging in"
@rebecacalvoquintero rebecacalvoquintero mentioned this issue Sep 29, 2017
Merged
Jen-Harris added a commit that referenced this issue Sep 29, 2017
@Jen-Harris
#1 responding to Dak's comments about validation restrictions'
4246840
Jen-Harris added a commit that referenced this issue Sep 29, 2017
@Jen-Harris
#1 wrote tests for validate email, password, confirm password and name.
506fb14 
Still need to write tests for validate registration and validate login
polyccon added a commit that referenced this issue Oct 3, 2017
@polyccon
Merge pull request #21 from FAC-11/validator
99987fb 
#1 started validator file
Jen-Harris added a commit that referenced this issue Oct 3, 2017
@Jen-Harris
#1 #5 adds signup file to verify whether user exists in the database
f41c47d
Jen-Harris added a commit that referenced this issue Oct 3, 2017
@Jen-Harris
#1 #5 fixes bugs, merge conflicts resolved
bf8cae4
Jen-Harris added a commit that referenced this issue Oct 3, 2017
@Jen-Harris
#1 #5 fixes bugs, merge conflicts resolved
c96a02f
@Jen-Harris Jen-Harris mentioned this issue Oct 3, 2017
Merged
Jen-Harris added a commit that referenced this issue Oct 3, 2017
@Jen-Harris
adding 4 tests to complete tests on validate.js
ebb8b3e 
relates #1
@Jen-Harris Jen-Harris mentioned this issue Oct 3, 2017
Merged
Jen-Harris added a commit that referenced this issue Oct 3, 2017
@Jen-Harris
#1 #5 working cookie and login!!!!
5774118
Jen-Harris added a commit that referenced this issue Oct 4, 2017
@Jen-Harris
fixes bug in tests
d6b4818 
reltates #1 #5
rebecacalvoquintero added a commit that referenced this issue Oct 4, 2017
@rebecacalvoquintero
#1 error-messages rendered on the page
c6d1264
@rebecacalvoquintero rebecacalvoquintero mentioned this issue Oct 4, 2017
Merged
3 tasks
rebecacalvoquintero added a commit that referenced this issue Oct 5, 2017
@rebecacalvoquintero
#1 #40 lock other pages from being rendered if the user has not logge…
e0c141c 
…d in or signed up, added part of the progress bar
@rebecacalvoquintero rebecacalvoquintero mentioned this issue Oct 5, 2017
Merged
dangerdak added a commit that referenced this issue Oct 10, 2017
@dangerdak
#1 links login and signup with database queries
5fafd33
dangerdak added a commit that referenced this issue Oct 10, 2017
@dangerdak
#1 password module no longer exports a function
7715f5a
@dangerdak dangerdak mentioned this issue Oct 10, 2017
Merged
dangerdak added a commit that referenced this issue Oct 10, 2017
@dangerdak
#1 shows error messages
7496f0a
dangerdak added a commit that referenced this issue Oct 11, 2017
@dangerdak
#1 Fixes login
efcc5ac
dangerdak added a commit that referenced this issue Oct 11, 2017
@dangerdak
#1 Removes test for validate login as i removed that function :)
a6d5460
Jen-Harris added a commit that referenced this issue Oct 11, 2017
@Jen-Harris
Merge pull request #66 from FAC-11/fix-signin
cdbf995 
#1 Fixes login
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rebecacalvoquintero rebecacalvoquintero

@Jen-Harris Jen-Harris

Labels
awaiting-review priority-2 T1d T4h
Projects
None yet
Milestone
Milestone 1
Development

No branches or pull requests
2 participants
@rebecacalvoquintero @Jen-Harris