Test and fix refactored action, with polling feature #14
Conversation
Before the key names were incorrect and therefore the output for the Harness Url was wrong, and couldn't be used to poll for the deploy result.
Needed because both the UI url and the API url are needed.
Because the GitHub actions log doesn't show the first few lines sometimes, it's impossible to view the Harness UI URL until the run is over, which isn't very useful. To fix that log the URL every time the action polls so you can't miss it!
singhprd
changed the title
singhprd
changed the title
| ["🚀 Deployment pipeline is now running on Harness"], | ||
| [ | ||
| "Harness deploy submitted, view at app.harness.io/#/account/aaa/app/bbb/pipeline-execution/ccc/workflow-execution/undefined/details", | ||
| ], |
There was a problem hiding this comment.
This test isn't ideal because it's too specific, but also because it doesn't actually test what we need it to here - that setting the wait for deploy option does something different. I'm pretty sure it's because the spy isn't the same instance as the one that is used by the watchDeployment function.
Leaving it here intentionally to follow back up on as a PR on it's own, rather than roll it into the wider PR here.
|
@stevenwilliamson did you leave a comment anywhere, or did I miss it!? 😄 If you're wondering about docs, I've already merged down some of this to main, and have updated the readme over there: |
|
Actually just going to merge this to |
Ensure the refactored action works as expected, and can poll for Harness deployment status.
Some follow up work and tidying up to do, but this does at least work:
https://github.com/fac/freeagent/runs/3482058001?check_suite_focus=true