Adds a style for freezing string literals #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Ruby 2.3, Ruby has had a MagicComment that can be added to the top of files. This makes all string literals frozen by default. This is a memory optimization; as the virtual machine doesn't allocate as many strings, it doesn't need to do as much garbage collection. See: https://www.mikeperham.com/2018/02/28/ruby-optimization-with-one-magic-comment for an example discussion, and http://ruby-performance-book.com/blog/2016/02/is-ruby-2-3-faster-frozen-string-literals-performance.html for another view Before merging this, we need to decide if we want to do this as a team. Note: [RFD in progress](https://docs.google.com/document/d/10Gt9BlxUbWE09-dTY21qpUARKpk8jrHYrLnDM_6nzCc)
|
@lylo are you happy for me to merge this branch down? |
|
@sarcas I don't think I need to sign these things off, probably not the best person these days! if there is team consensus it's fine by me |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since Ruby 2.3, Ruby has had a MagicComment that can be added to the top of files. This makes all string literals frozen by default. This is a memory optimization; as the virtual machine doesn't allocate as many strings, it doesn't need to do as much garbage collection.
See: https://www.mikeperham.com/2018/02/28/ruby-optimization-with-one-magic-comment for an example discussion, and http://ruby-performance-book.com/blog/2016/02/is-ruby-2-3-faster-frozen-string-literals-performance.html for another view
Before merging this, we need to decide if we want to do this as a team.
Note: RFD in progress