Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process Guide #21

Open
12 tasks
HettieM opened this issue May 18, 2020 · 0 comments
Open
12 tasks

Process Guide #21

HettieM opened this issue May 18, 2020 · 0 comments
Labels
documentation Improvements or additions to documentation

Comments

@HettieM
Copy link
Collaborator

HettieM commented May 18, 2020

Overview

This issue is intended to document for our current processes within this project.
This issue must not be edited without the full agreement of all members of the team.

Priorities

What do we want to achieve in this project?

  • Semantic HTML
  • Forms appropriately labelled
  • Site accessible by keyboard navigation
  • Avoid divs
  • Use aria labels
  • Use TDD
  • Implementing Jest testing FE & BE (J)
  • Setting up a CI workflow (J)

Stand-ups

Stand ups will be held at 5:30 for 15 minutes.

  • What you have done
  • What you plan to do next + what else your task needs working on
  • Blockers
    Please review the kanban daily and check it is up to date.

Workflow

  • Issues to be added by scrum master
  • Issues will be fleshed out by those working on them, processes defined step-by-step with checkboxes
  • Remember to link issues to kanban board
  • P0 bugs (with red label) for issues that need to be resolved immediately - can be added by anyone
  • Assign yourself to issues that you are working on
  • Be sure to review code before merging pull request (ask for walkthrough if you don't understand)

Pre-pull-request Checklist

  • Master branch up to date and merged into current branch
  • Lint + prettier used
  • Tests passing
  • No console.log

Naming Branches

Follow convention (issue number)-feature/fix-branch-name
e.g. 13-feature-add-search-function AND 20-fix-change-searchbar-colour

Commit messages

  • Include issue #
  • Write imperative tone (describe what the commit does, not what it did)
  • Write with correct grammar
  • Remember to co-author

Modules

  • Installed modules should be described on the project readme

React Component File Structure

  • Include subfolders for
  • Customers
  • Vendors
  • Shared
  • Each component should have individual JS, test and style files

Styled Components

Please follow the style guide for global css variables

Constants Folder

  • Use constants folder to hold ALL routes for an easy update at later dates.
@HettieM HettieM added the documentation Improvements or additions to documentation label May 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant