Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inputs need labels with content #10

Open
oliverjam opened this issue Jun 9, 2022 · 1 comment
Open

Inputs need labels with content #10

oliverjam opened this issue Jun 9, 2022 · 1 comment

Comments

@oliverjam
Copy link

<label htmlFor="search">
<input
type="search"
name="search"
id="search-form"
placeholder="Search for..."
/>
</label>

You have added a <label> element here, but there's no text in it, so the user doesn't know what the input does. If you think it's visually obvious that it's a search input then you should at least add an aria-label so that users who cannot see it will also know what the input is for

minju25kim added a commit that referenced this issue Jun 10, 2022
@minju25kim
Copy link
Contributor

added search label content for readability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants