facade/ignition#302: Fix memory leaks caused by log and query recorder

[TheLevti]

• Add optional log recorder limit to prevent memory leaks. Especially
  noticeable during long running tasks or daemons.
• Rewrote query recorder to not tightly couple it with the framework
  container when deciding whether to include bindings or limit the
  maximum query count that is recorded.
• Added a config flag to disable log recording all together.
• Made sure that query and log recorders are not used when their enable
  flag is disabled.

Closes #302

Closes #301

[freekmurze]

On first sight, this seems ok to me.

@AlexVanderbist can you review and merge this?

[rubenvanassche]

Some minor changes request, but a great PR, look forward to merge it!

[AlexVanderbist]

Apart from the minor remarks by my colleagues; LGTM!

[rubenvanassche]

Thanks, looks great!

[rimace]

This change is causing a memory leak for me.
I am importing ~300,000 models. First 1,000 models are read and bundled into one transaction, then the query is fired and then next 1,000 and so on.
Usually my import uses always around 25 MB RAM, but since version 2.5.11 my importer reaches 500 MB RAM after a while.
Will report a proper issue with an example later today.

[TheLevti]

This change is causing a memory leak for me.
I am importing ~300,000 models. First 1,000 models are read and bundled into one transaction, then the query is fired and then next 1,000 and so on.
Usually my import uses always around 25 MB RAM, but since version 2.5.11 my importer reaches 500 MB RAM after a while.
Will report a proper issue with an example later today.

Thanks for the feedback. Please let me know the details. For my use case the memory leak that I had previously was fixed once the array is topping out at the configured limit.

[rimace]

That's it.
The QueryRecorder uses a new config which didn't exist in my config cache (forgot to recreate it).
Because QueryRecorder was activated but the maximum_number_of_collected_logs didn't exist in my config cache yet, it was null which deactivated the "maximum logs" of 200 (by default).
So it was my fault for not recreating the config cache. Still I think the name of the config variable is wrong there.