Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npm ci instead of install #411

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

jonassiewertsen
Copy link
Contributor

I would suggest to use npm ci instead of npm install.

npm ci does only install dependencies as locked in the package.lock file. This does mean, that npm ci can be compared with composer install in PHP.

Why not to use install
Install might update dependencies and might create a new package.lock.

Downsides of install
In case someone does not have a package.lock file, npm will throw an error message saying that you need to run npm install.

This may sound like a downside, but personally I think this is fine as the same is required if using composer install in PHP.

@freekmurze freekmurze merged commit e0a99ca into facade:main Aug 17, 2021
@freekmurze
Copy link
Collaborator

Thanks!

@freekmurze
Copy link
Collaborator

✅ Ported to spatie/laravel-ignition

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants