You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When [Tag] attribute is placed on overriding method - it is ignored. However [DisplayName] follows overridden method attribute.
I think that Hangfire.Tags behavior should be aligned with the Hangfire behavior.
[Tag("base-class")]
public class BaseService
{
[Tag("base-method")]
[DisplayName("base-method")]
public virtual void Run()
{
}
}
[Tag("overriding-class")]
public class OverridingService : BaseService
{
[Tag("overriding-method")]
[DisplayName("overriding-method")]
public override void Run()
{
base.Run();
}
}
Note1: I tested it also using PostgreSql Storage so it doesn't seem to be storage related.
Note2: There is other issue present in my example url (not related to this one)
The text was updated successfully, but these errors were encountered:
Hangfire.Tags CreateJobFilter - TagAttribute handling. It seems like the Hangfire.Core itself is returning base method reference from filterContext.Job.Method
Fixed in 1.7.2. Basically: the filterContext contains the basetype of the method, and the type on which execution should take place. The dashboard get's the type on the derived type.
Hello,
I prepared minimal example of the issue here
When [Tag] attribute is placed on overriding method - it is ignored. However [DisplayName] follows overridden method attribute.
I think that Hangfire.Tags behavior should be aligned with the Hangfire behavior.
Note1: I tested it also using PostgreSql Storage so it doesn't seem to be storage related.
Note2: There is other issue present in my example url (not related to this one)
The text was updated successfully, but these errors were encountered: