This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
Add download resume support #3246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nguyenhuy
suggested changes
Apr 10, 2017
Source/Details/ASImageProtocols.h
Outdated
| `downloadImageWithURL:callbackQueue:downloadProgressBlock:completion:`. | ||
| @discussion This method has no effect if `downloadIdentifier` is nil. If implemented, this method | ||
| may be called instead of `cancelImageDownloadForIdentifier:` in cases where ASDK believes there's a chance | ||
| the image download will be resumed (currently when an image exits display range). You can use this to store |
There was a problem hiding this comment.
nit: "currently when an image exits preload range"
Source/ASNetworkImageNode.mm
Outdated
| @@ -107,7 +109,7 @@ - (instancetype)init | |||
|
|
|||
| - (void)dealloc | |||
| { | |||
| [self _cancelImageDownload]; | |||
| [self _cancelImageDownload:NO]; | |||
There was a problem hiding this comment.
The new boolean param passed to _cancelImageDownload: is not descriptive and thus a bit confusing. How about _cancelImageDownloadWithResumePossibility:? Same concern for _cancelDownloadAndClearImage: and their _locked variants.
nguyenhuy
approved these changes
Apr 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds resume support support for image downloads that have exited preload range (only on ASNetworkImageNode currently).