clarify how integer RangeParameters are rounded #134
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
Addresses #133 |
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=======================================
Coverage 95.35% 95.35%
=======================================
Files 225 225
Lines 13207 13207
=======================================
Hits 12593 12593
Misses 614 614Continue to review full report at Codecov.
|
Summary: Pull Request resolved: #134 see title Reviewed By: sdsingh Differential Revision: D16604103 fbshipit-source-id: ad63a528fa3ad087cf10333c7c596210da9d41df
|
This pull request has been merged in 93145fa. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: see title
Differential Revision: D16604103