Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add improvement_to_baseline for SOO cases #2046

Closed
wants to merge 1 commit into from

Conversation

mgrange1998
Copy link
Contributor

Summary: Adding functionality for adding "improvement_over_baseline" from a scheduler object.

Differential Revision: D51726168

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Dec 5, 2023
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51726168

@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (79133c7) 94.52% compared to head (6403310) 94.53%.

❗ Current head 6403310 differs from pull request most recent head 3d6ba1e. Consider uploading reports for the commit 3d6ba1e to get more accurate results

Files Patch % Lines
ax/service/scheduler.py 92.30% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2046   +/-   ##
=======================================
  Coverage   94.52%   94.53%           
=======================================
  Files         460      460           
  Lines       44522    44575   +53     
=======================================
+ Hits        42086    42137   +51     
- Misses       2436     2438    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

mgrange1998 pushed a commit to mgrange1998/Ax that referenced this pull request Dec 5, 2023
Summary:

Adding functionality for adding "improvement_over_baseline" from a scheduler object.

Differential Revision: D51726168
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51726168

mgrange1998 pushed a commit to mgrange1998/Ax that referenced this pull request Dec 6, 2023
Summary:

Adding functionality for adding "improvement_over_baseline" from a scheduler object.

Reviewed By: mpolson64

Differential Revision: D51726168
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51726168

Summary:

Adding functionality for adding "improvement_over_baseline" from a scheduler object.

Reviewed By: mpolson64

Differential Revision: D51726168
@facebook-github-bot
Copy link
Contributor

This pull request was exported from Phabricator. Differential Revision: D51726168

mgrange1998 pushed a commit to mgrange1998/Ax that referenced this pull request Dec 6, 2023
Summary:

Adding functionality for adding "improvement_over_baseline" from a scheduler object.

Reviewed By: mpolson64

Differential Revision: D51726168
mgrange1998 pushed a commit to mgrange1998/Ax that referenced this pull request Dec 6, 2023
Summary:

Adding functionality for adding "improvement_over_baseline" from a scheduler object.

Reviewed By: mpolson64

Differential Revision: D51726168
mgrange1998 pushed a commit to mgrange1998/Ax that referenced this pull request Dec 6, 2023
Summary:

Adding functionality for adding "improvement_over_baseline" from a scheduler object.

Reviewed By: mpolson64

Differential Revision: D51726168
@facebook-github-bot
Copy link
Contributor

This pull request has been merged in f76f721.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. fb-exported Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants