Ban spaces in metric/parameter names in AxClient #2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
mpolson64
force-pushed
the
export-D56576451
branch
from
bec6d6b
to
67c69c4
Compare
Summary: Spaces in names break parsing needed for contraints in AxClient. We discussed many options fo rmoving forward here but this simple solution is the least disruptive Reviewed By: bernardbeckerman Differential Revision: D56576451
mpolson64
force-pushed
the
export-D56576451
branch
from
67c69c4
to
50be52b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2397 +/- ##
==========================================
+ Coverage 94.91% 95.30% +0.39%
==========================================
Files 491 495 +4
Lines 47788 48401 +613
==========================================
+ Hits 45356 46130 +774
+ Misses 2432 2271 -161 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Spaces in names break parsing needed for contraints in AxClient. We discussed many options fo rmoving forward here but this simple solution is the least disruptive
Differential Revision: D56576451