Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

array has incomplete element type 'struct rcd_rebinding' #11

Closed
crespoxiao opened this issue Jun 3, 2016 · 5 comments
Closed

array has incomplete element type 'struct rcd_rebinding' #11

crespoxiao opened this issue Jun 3, 2016 · 5 comments

Comments

@crespoxiao
Copy link

crespoxiao commented Jun 3, 2016

hey there,when i import this library,appears the compile problem "array has incomplete element type 'struct rcd_rebinding'",i set the file name AppDelegate.mm and import libc++.tbd still can not fix this problem.any good suggestion ? thanks.

1

@crespoxiao
Copy link
Author

to the guys who searched this issue,
it's not a common problem.the reason of this error is my workspace has 2 fishhook class files, one belongs to FBRetainCycleDetector lib and another belongs to a private lib. just keep one and it would be ok.

@kastiglione
Copy link
Contributor

Thanks for the report, and the follow up.

I think FBRetainCycleDetector should either:

  1. Add rcd_ prefix to fishhook.h
  2. Remove rcd_ prefixes from functions in fishhook.h

Option 2 should be possible following facebook/fishhook#29

@k0nserv
Copy link

k0nserv commented Oct 10, 2017

I'm also seeing this with React Native 0.49.0 which introduced a fishhook in facebook/react-native@878b7e4. This causes a conflict because the project also depends on FBMemoryProfiler which in turn has a dependncy on FBRetainCycleDetector where another fishhhook exists.

Is the only solution for this issue to remove one of the two?

@kastiglione
Copy link
Contributor

kastiglione commented Oct 10, 2017

@k0nserv do you mind pasting the compilation error?

It should be achievable to have both use fishhook independently without conflict.

@k0nserv
Copy link

k0nserv commented Oct 10, 2017

It's the same as above regarding rcd_rebinding. I got lucky and we had stopped using FBMemoryProfiler so I could just remove it leaving us only with the FBRetainCycleDetector from React Native

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants