Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road connectivity warnings don't update when connected #1125

Closed
Sellyme opened this issue Sep 22, 2023 · 3 comments
Closed

Road connectivity warnings don't update when connected #1125

Sellyme opened this issue Sep 22, 2023 · 3 comments
Labels
feature-validator Issue or request related to the validator

Comments

@Sellyme
Copy link

Sellyme commented Sep 22, 2023

Description

Under some circumstances when making additions to the road network, a newly created (unconnected) road will display a warning upon its addition to the map, but not get rid of this warning when a new road is created connecting it to the rest of the network. The warning seems to only go away if the original way is modified further after having been connected to the network.

Version

2.1.1

What browser are you seeing the problem on? What version are you running?

Firefox 117.0.1 (64-bit)

The OS you're using

Windows 10 Home

Steps to reproduce

  1. Find an area with incomplete road mapping:

image

  1. Create a way that is not yet connected to the pre-existing road network, and tag it appropriately:

image

  1. Noting the error that has appeared, create a new way connecting this road to the existing road network:

image

  1. Observe that the existing way still has a now-incorrect warning:

image

  1. At this stage, any movement of any node attached to the way created in step 2 will result in the error message going away, even if the modification is immediately undone. So the engine is aware that the way is connected, it's just not checking to see if the status of the way has changed on connections, only on modifications.

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&id=w-81&map=19.42/-33.72847/150.88405&overlays=osm-gps&poweruser=true

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

No response

@jjiglesiasg
Copy link

Already reported since 2.0, still not solved..

@bhousel
Copy link
Contributor

bhousel commented Oct 4, 2023

Yeah, this one is something that has been around since the iD code. I think it could probably be solved simply by remembering the entities that are involved in this class of issues and check them again sometimes as edits happen.
openstreetmap/iD#8758

@bhousel bhousel added the feature-validator Issue or request related to the validator label Oct 4, 2023
@jjiglesiasg
Copy link

By the way this issue create a permanent "Issue (errot)" in OSMI for routing, likewise when you add a NoExit tag at the end of the road, if it's close to another way. OSMI and OSMOSE both keep the issue open...

@bhousel bhousel closed this as completed in 2de37bc Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-validator Issue or request related to the validator
Projects
None yet
Development

No branches or pull requests

3 participants