Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cursors moved to eventManager #1249

Merged
merged 3 commits into from
Dec 5, 2023
Merged

Cursors moved to eventManager #1249

merged 3 commits into from
Dec 5, 2023

Conversation

tannerwuster
Copy link
Contributor

Description

Cleaned up the cursor code to work within evenManager instead of within the indexes of behaviors and modes. This also fixes #1225

@tannerwuster tannerwuster marked this pull request as ready for review December 4, 2023 20:19
@tannerwuster tannerwuster self-assigned this Dec 4, 2023
bhousel
bhousel approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@bhousel bhousel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! I like having the cursors in one place, much cleaner than having those export const cursors = {} in the modes and behaviors.

@bhousel bhousel merged commit b23d8e5 into main Dec 5, 2023
5 checks passed
@bhousel bhousel deleted the cursors_test_staging branch December 5, 2023 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhousel bhousel bhousel approved these changes

Assignees

@tannerwuster tannerwuster

Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cursor image not found
3 participants
@tannerwuster @bhousel @facebook-github-bot