Fix 3D map toggle in side bar #1282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannerwuster
changed the title
tannerwuster
force-pushed
the
3D_map_menu_fix
branch
from
df2751a
to
730b021
Compare
bhousel
reviewed
Jan 2, 2024
| @@ -277,7 +274,6 @@ export function uiMap3dViewer(context) { | |||
| map.on('draw', () => redraw()); | |||
| map.on('move', () => redraw()); | |||
| context.keybinding().on([uiCmd('⌘' + l10n.t('background.3dmap.key'))], toggle); | |||
| urlhash.on('hashchange', toggle); | |||
There was a problem hiding this comment.
My initial thought is that it would be a shame to lose the connection between the map3d urlhash param, and the state of the viewer, but looking elsewhere around the code it seems like this was never really set up correctly so we aren't losing anything.
I expect it to work like this:
- checking/unchecking the box updates the
map3d=trueto the urlhash
(something likeurlhash.setParam('map3d', !_isHidden ? 'true' : null)) - changing the urlhash updates the state of the box and viewer
(something likeurlhash.on('hashchange', doStuff))
Basically we should just look at how PhotoSystem or ImagerySystem works and make Map3dSystem work more like those.
Anyway, I'm going to just merge this because we need to patch the bug, but we should improve this later.
bhousel
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue that if you check the 3D checkbox to show 3D map, nothing happens. This now works and fixes #1273