Multiple crossing nodes on crossing way not tagged correctly

[atiannicelli]

Description

If I try to use the "Tag this crossing as 'lines'" suggestion to fix a way with two crossings on it then it does not make the change that I asked it to make. (See steps to reproduce for details)

Screenshots

Before fixing the intersection:

After clicking on "Tag this crossing as 'lines'"

Version

2.2.3

What browser are you seeing the problem on? What version are you running?

Chrome v120.0

The OS you're using

mac

Steps to reproduce

I have a way with the following tags

crossing=marked
crossing:markings=yes
footway=crossing
highway=footway

and TWO nodes on that way that have the following tags:

crossing=marked
crossing:markings=lines
highway=crossing

When I click on the way it gives me this warning:

Crossing line and point tags conflict

Tag this crossing as 'marked'
Tag this crossing as 'lines'
Remove all crossing tags
Ignore this issue

I then click on the "Tag this crossing as 'lines'" and instead of the way being changed to crossing:marking=lines it changes the nodes to crossing:marking=yes.

If I remove one of the crossing nodes (and the way that it is on) then it behaves correctly so I think this is specific to having two crossing nodes on the crossing way.

The browser URL at the time you encountered the bug

https://rapideditor.org/edit#background=Bing&datasets=fbRoads,msBuildings&disable_features=boundaries&id=w706113826&map=20.00/42.34726/-88.13017

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/120.0.0.0 Safari/537.36

[bhousel]

Whoa good catch @atiannicelli - this was a caused by an unfortunate typo that only occured if that part of code was visited more than once. Easy fix though, I'll get a patch out soon.