Add duplicate way validation #220
Conversation
| // Consider a way to be routable if it is a highway, railway, or wateray. | ||
| // if it is an area of any kind, it is not routable. | ||
| function hasRoutableTags(way) { | ||
| if (Object.keys(way.tags).some(isAreaTag)) return false; |
There was a problem hiding this comment.
Checking whether a geometry is an area is a bit more complicated than just looking for an area tag...
Way has a builtin method way.isArea() to do it.
|
|
||
|
|
||
| function getIssuesForWay(way) { | ||
| var issues = [], |
There was a problem hiding this comment.
Can we stick the hasRoutableTags check here at the very beginning? I'm thinking it could avoid looping through all the nodes and make this code much more performant..
|
Looks good! Another thing I was thinking (aside from the above code comments) was that #212 had requested validations for a bunch of duplicate way issues. This PR just handles a subset of the issues, but can we expand the code later to catch more? I think what I'm asking is if the code is organized in a way that in the future we can add more of these kinds of |
I'll ask @atiannicelli what he thinks about whether this check should get more involved before we add it. |
|
Any incremental changes we can make to get closer to the desired state I am fine with. If this doesn't solve all the parts of that issue then I'll split out the things it doesn't into another issue so we can close one and keep the other around. |
|
Sounds good- I'll address Bryan's first couple of comments and then get this updated, then we can ship, then re-do the task, and iterate! |
|
@bhousel doink! I have promoted this PR to 'ready for review'. |
|
Looks great! Thanks @Bonkles 🎉 |
This check adds a duplicate way validation to RapiD, by looking for single-segment ways that share the same two endpoint locations. If such segments are found, we highlight the endpoints in a validation entry.