Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapillary v4 #236

Merged
merged 8 commits into from
Jun 21, 2021
Merged

Mapillary v4 #236

merged 8 commits into from
Jun 21, 2021

Conversation

nickplesha
Copy link

Hi!

This PR updates the Mapillary integration to use the new API (v4). Documentation is here: https://www.mapillary.com/developer/api-documentation/

Changes:

  • Uses latest vector tiles for images, sequences, traffic signs and map features
  • Uses latest API for image detections
  • Uses latest Mapillary JS
  • Removes a bunch of obsolete code
  • Simplifies the state in the Mapillary service
  • Fixes unit tests
  • Fixes a bunch of bugs

Let me know if you have any questions or feedback.

Copy link
Contributor

@Bonkles Bonkles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good at first glance, Let me enable the build to fire and I will deploy a test version of this code up on the site, and we can tire-kick live.

@Bonkles
Copy link
Contributor

Bonkles commented Jun 15, 2021

test deploy is live at: https://mapwith.ai/rapid/f7402013a-dist/index.html

I have rebuilt the translations using npm run translate but it still seems there are a bunch of issues. @bhousel can you take a look?

@nickplesha
Copy link
Author

I noticed the translation errors when the map feature layer is on. It comes from the map feature "title" which is not displayed anywhere so I removed it.

Copy link
Contributor

@Bonkles Bonkles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like these latest changes fixed the error messages! Thanks!

@Bonkles Bonkles merged commit 4f67355 into facebook:main Jun 21, 2021
@bhousel bhousel added this to the v.next milestone Jul 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants