Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom when selecting an AI detected object (road, building) #866

Closed
Marc-marc-marc opened this issue Mar 27, 2023 · 2 comments
Closed

Zoom when selecting an AI detected object (road, building) #866

Marc-marc-marc opened this issue Mar 27, 2023 · 2 comments
Labels
feature-usability Issue or feature related to usability - something hard to do good first issue Good for newcomers

Comments

@Marc-marc-marc
Copy link

Description

when selecting an AI detected road, I need to zoom to see if it's a valid detection or not, and also to ajust the geometry

request :
auto-zoom to the object (always, or user setting or via a button under "use this feature"

Version

2.0.0-beta.0

What browser are you seeing the problem on? What version are you running?

Firefox v102.0

The OS you're using

Linux (Centos)

Steps to reproduce

be on zoom 16
select any AI detected road
see that you can't really decide if you'll use this feature or ignore it until you zoom a lot

The browser URL at the time you encountered the bug

https://mapwith.ai/rapid-v2-beta#background=swisstopo_swissimage&datasets=fbRoads,msBuildings&disable_features=boundaries&map=16.00/46.8756/6.9888

The auto-detected useragent string for your browser (leave blank if you're manually filling this form out)

No response

@bhousel
Copy link
Contributor

bhousel commented Mar 29, 2023

I probably wouldn't want to automatically zoom, but we should support the Z zoom in hotkey like we do for the OSM features.

@bhousel bhousel added feature-usability Issue or feature related to usability - something hard to do good first issue Good for newcomers labels Mar 29, 2023
@bhousel bhousel changed the title Auto-zoom when selecting an AI detected object (road, building) Zoom when selecting an AI detected object (road, building) Mar 29, 2023
@bhousel
Copy link
Contributor

bhousel commented Apr 12, 2023

Ok, zoomers! I updated the "Zoom to selection" tool so that it now works with any selection.. Before it only worked with OSM data.

Now if a mode exposes an extent property, the "Zoom to selection" tool will zoom in on it if the user clicks the button or presses Z. Clicking or pressing Z again will pop back out to whatever the user was looking at before.

This works for both the legacy OSM select mode and the new select mode that handles notes, custom data, QA items like Keepright or Osmose, and Rapid data.

Here's me checking out some Microsoft buildings.

zoominout

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-usability Issue or feature related to usability - something hard to do good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants