Skip to content

Commit

Permalink
Use venv rather than virtualenv (#357)
Browse files Browse the repository at this point in the history
Summary:
Use venv rather than virtualenv

venv has been included as part of the python standard library since 3.3 -- no need to install the third-party virtualenv module

 ---
[//]: # (BEGIN SAPLING FOOTER)
Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/TestSlide/pull/357).
* #359
* __->__ #357

Pull Request resolved: #357

Differential Revision: D55365458

Pulled By: shish

fbshipit-source-id: 0312bd52e37ba4d78572dcd2d616578dd820a92f
  • Loading branch information
shish authored and facebook-github-bot committed Mar 26, 2024
1 parent 57a19fa commit 57e5008
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 3 deletions.
2 changes: 0 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ jobs:
uses: actions/setup-python@v2
with:
python-version: ${{ matrix.python-version }}
- name: Install virtualenv
run: pip install virtualenv
- name: Run Tests
run: TESTSLIDE_FORMAT=progress UNITTEST_VERBOSE=0 make ci V=1
- name: Coveralls
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ all: tests coverage_report docs sdist
##
venv: requirements-dev.txt requirements.txt
@printf "${TERM_BRIGHT}CREATE VIRTUALENV (${CURDIR}/venv)\n${TERM_NONE}"
${Q} python3 -m virtualenv venv
${Q} python3 -m venv venv
@printf "${TERM_BRIGHT}INSTALL BUILD DEPS\n${TERM_NONE}"
${Q} ${CURDIR}/venv/bin/pip install -r requirements-dev.txt
@printf "${TERM_BRIGHT}INSTALL DEPS\n${TERM_NONE}"
Expand Down

0 comments on commit 57e5008

Please sign in to comment.