-
Notifications
You must be signed in to change notification settings - Fork 56
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Thread a control flag for asyncio debug through the CLI and Runner (#342
) Summary: Pull Request resolved: #342 Context == The existing TestSlide runner always enables the asyncio debug flag, which enables slow callback detection etcetera. There can be cases where the server running the test is overloaded, and random tests will fail due to Python being unable to execute the async callback fast enough. A flag to control this behaviour can be useful when code is known to have slow async callbacks - the source should still be addressed, but disabling the test-failing behaviour enables the code author to check that everything else is ok. Implementation == * Add CLI support for `--slow-callback-is-not-fatal` * Add Runner support for an `slow_callback_is_not_fatal` parameter that defaults `False` to keep existing behaviour * Fix a typo in `dsl_unittest.py` Reviewed By: deathowl Differential Revision: D41802046 fbshipit-source-id: 60a5e6db71690b6a421d9bf91940820c8be58f43
- Loading branch information
1 parent
61b016b
commit eb0e389
Showing
4 changed files
with
33 additions
and
8 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters