Add type validation to mock constructor #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
This was
linked to
issues
Apr 8, 2020
fornellas
force-pushed
the
add_type_validation_to_mock_constructor
branch
from
5c905e3
to
7bb043d
Compare
|
@david-caro your #149 fix worked, thanks! |
fornellas
force-pushed
the
add_type_validation_to_mock_constructor
branch
from
7bb043d
to
9f1bf7c
Compare
david-caro
approved these changes
Apr 9, 2020
| messenger_mock = testslide.StrictMock(template=Messenger) | ||
| self.mock_constructor(sys.modules[__name__], "Messenger").to_return_value(messenger_mock) | ||
| with self.assertRaises(TypeError): | ||
| # TypeError: Call with incompatible argument types: |
There was a problem hiding this comment.
nit: indents are weird (2 spaces here, 4 in the block before)
There was a problem hiding this comment.
Fixed this on master after the merge, tkz.
| if target_class_id in _target_class_id_by_original_class_id: | ||
| raise RuntimeError("Can not mock the same class at two different modules!") | ||
| else: | ||
| _target_class_id_by_original_class_id[id(original_class)] = target_class_id | ||
|
|
||
| original_class_new = original_class.__new__ |
There was a problem hiding this comment.
I would have forgotten about new xd
There was a problem hiding this comment.
Turns out, it is there only for being future proof, as mock_constructor() currently can't handle classes that define their own __new__: #155.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ditto.
This is currently failing due to #145, tests will likely pass once that's fixed.
Closes #146.
Closes #142.