[signature validation] Skip TypeVar signatures #164
Conversation
facebook-github-bot
added
the
CLA Signed
testslide/lib.py
Outdated
| @@ -82,17 +82,33 @@ def _validate_function_signature( | |||
| expected_type = argspec.annotations.get(argname) | |||
| if not expected_type: | |||
| continue | |||
|
|
|||
| if '~' in str(expected_type): | |||
There was a problem hiding this comment.
Is there a more thorough way of detecting this? Eg: isinstance?
There was a problem hiding this comment.
The problem is that it can be nested, like Type[~Something], Optional[Tuple[int, Tuple[str, ~Something]]], and I did not want to have to implement the unwrapping of that, but as str already does and ~ is kinda unique, seems like a good trade-off.
But yes, I think that eventually we will have to unwrap that, at that point we can use that here instead.
There was a problem hiding this comment.
That's reasonable for the time being, NP.
There was a problem hiding this comment.
LGTM, just please fix the nits & builds before merging (black should do it).
I registered #165 to eventually implement this. Thanks @david-caro !
In order to be able to check TypeVars we have to be able to check the whole signature type hints at the same time (as typevars are dynamically defined). This just skips them for now to avoid failing the type checks. It's using the `str` method of the type hint to traverse the type definition and see if there are any typevars (prefixed with `~`), it's a hacky way, but quite effective until we have the need to traverse the type hint ourselves, at that point we can use that instead.
david-caro
force-pushed
the
skip_typevar_signature_checks
branch
from
57646a7
to
d8cc163
Compare
In order to be able to check TypeVars we have to be able to check the
whole signature type hints at the same time (as typevars are dynamically
defined).
This just skips them for now to avoid failing the type checks.
It's using the
strmethod of the type hint to traverse the typedefinition and see if there are any typevars (prefixed with
~), it's ahacky way, but quite effective until we have the need to traverse the
type hint ourselves, at that point we can use that instead.