Fix mock callable/constructor to not accept extra configuration after…

[ldfsilva]

What:

This fixes issue 16, not allowing that extra configuration is made after mock_callable, mock_async_callable or mock_constructor` receive their first call.

Added tests to cover the constraint to not allow extra configuration to be made in mock_callable, mock_async_callable and mock_constructor and also validated with ad-hoc tests that TestSlide tests continues to behave as expected. As show below:

For the ad-hoc tests I used this test_extra_configuration.py and invoked tests as follows:

python -m unittest -v tests.test_extra_configuration

Here are excerpts from the test results: [here]

mock_async_calable:

ERROR: test_mock_async_callable_fail_already_received_1_call (tests.test_extra_configuration.TestCase)
ValueError: No extra configuration is allowed after mock_async_callable receives its first call, it received 1 call already. You should instead define it all at once, eg: self.mock_async_callable(target, 'func').to_return_value(value).and_assert_called_once()

ERROR: test_mock_async_callable_fail_already_received_8_calls (tests.test_extra_configuration.TestCase)
ValueError: No extra configuration is allowed after mock_async_callable receives its first call, it received 8 calls already. You should instead define it all at once, eg: self.mock_async_callable(target, 'func').to_return_value(value).and_assert_called_once()

mock_calable:

ERROR: test_mock_callable_fail_already_received_1_call (tests.test_extra_configuration.TestCase)
ValueError: No extra configuration is allowed after mock_callable receives its first call, it received 1 call already. You should instead define it all at once, eg: self.mock_callable(target, 'func').to_return_value(value).and_assert_called_once()

ERROR: test_mock_callable_fail_already_received_8_calls (tests.test_extra_configuration.TestCase)
ValueError: No extra configuration is allowed after mock_callable receives its first call, it received 8 calls already. You should instead define it all at once, eg: self.mock_callable(target, 'func').to_return_value(value).and_assert_called_once()

mock_constructor:

ERROR: test_mock_constructor_fail_already_received_1_call (tests.test_extra_configuration.TestCase)
ValueError: No extra configuration is allowed after mock_constructor receives its first call, it received 1 call already. You should instead define it all at once, eg: self.mock_constructor(target, 'func').to_return_value(value).and_assert_called_once()

ERROR: test_mock_constructor_fail_already_received_8_calls (tests.test_extra_configuration.TestCase)
ValueError: No extra configuration is allowed after mock_constructor receives its first call, it received 8 calls already. You should instead define it all at once, eg: self.mock_constructor(target, 'func').to_return_value(value).and_assert_called_once()

[deathowl]

LGTM. @ldfsilva Just fix the breaking testcase plase :)

[ldfsilva]

sounds good, I just noticed that we have a designated test file for mock_async_callable (need glasses), so I relocated that test over there, removed asyncio.run and fixed linter, it should be good now.

[fornellas]

I think we can drop the name argument here, as it can (should!) be accessed with self._NAME.

[fornellas]

Thanks @ldfsilva for working on this! Small, focused and with awesome simple test coverage!