Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak test report #270

Merged
merged 5 commits into from
Jan 7, 2021
Merged

Tweak test report #270

merged 5 commits into from
Jan 7, 2021

Conversation

fornellas
Copy link
Contributor

@fornellas fornellas commented Nov 19, 2020

Tweak the test execution report to:

  • Show successful, failed, skipped and not executed tests even when it is 0.
    • It is printed in dim white in this case.
    • When there's 1+ examples, it is printed with the same usual color code (green, red, yellow, cyan).
  • Improve the message for slow imports, making it more visible and hinting what to do next.
  • Add link to documentation: despite being comprehensive, few people refer to it, let's make this better.
  • Add nice colored ASCII colored logo, because why not help branding ¯_(ツ)_/¯

image

@fornellas
Copy link
Contributor Author

fornellas commented Nov 19, 2020

@deathowl do you know about these 2 build errors?

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Nov 19, 2020
@deathowl
Copy link
Member

deathowl commented Jan 6, 2021

@deathowl do you know about these 2 build errors?

i think rebase should resolve them

@fornellas
Copy link
Contributor Author

I'll move this logo to the right in the next week or so, so it is not annoying to users.

@fornellas
Copy link
Contributor Author

Moved logo to the right of the screen so it does not annoy:

  • If stdout is a terminal:
    • if columns > 80 then it caps the logo to the 80th column (so it does not goes all the way to the right on big terminals).
    • else
      • if it can fit the logo then print it
      • else does not print it
  • else
    • print the logo as if the terminal had 80 columns.

image

@fornellas fornellas merged commit c47bf38 into master Jan 7, 2021
@fornellas fornellas deleted the add_logo branch January 7, 2021 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants