Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve reset attribute error message & docs #281

Closed
wants to merge 1 commit into from

Conversation

fornellas
Copy link
Contributor

The previous exception message was wrong and confusing. This PR improves this message and the corresponding documentation.

@facebook-github-bot facebook-github-bot added the CLA Signed Do not delete this pull request or issue due to inactivity. label Feb 5, 2021
@coveralls
Copy link

Pull Request Test Coverage Report for Build 540237892

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 94.069%

Totals Coverage Status
Change from base Build 537663247: 0.0%
Covered Lines: 2522
Relevant Lines: 2681

💛 - Coveralls

Copy link

@facebook-github-bot facebook-github-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fornellas has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@fornellas merged this pull request in 65dafe9.

@fornellas fornellas deleted the improve_reset_attr_docs branch February 22, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed Do not delete this pull request or issue due to inactivity. Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants