When complaining about a formatting error, say what the error is #363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 26, 2024
Closed
facebook-github-bot
added
the
CLA Signed
I'm getting an error which _only_ appears on python 3.7 and I can't repro it locally, and CI won't tell me what the error is x_x
|
@shish has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 26, 2024
Summary: Fix type signatures in sample module mypy is complaining about this and failing all of the builds, and there's no comment saying "this mistake is intentional", so I assume it is an accident --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/TestSlide/pull/361). * #362 * #363 * __->__ #361 Pull Request resolved: #361 Differential Revision: D55365462 Pulled By: shish fbshipit-source-id: 61cac16eeb3bac081ce95fe7fde3e6f9b4d4b693
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When complaining about a formatting error, say what the error is
I'm getting an error which only appears on python 3.7 and I can't repro it locally, and CI won't tell me what the error is x_x