Enable custom logging format #1582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dcallies
approved these changes
Apr 25, 2024
|
|
||
| class CustomJsonFormatter(jsonlogger.JsonFormatter): | ||
| """ | ||
| Outputs logs in a JSON format. |
There was a problem hiding this comment.
You could mention the framework this would be used with here to help folks figure out what it's used for.
There was a problem hiding this comment.
By framework, do you mean flask? Or the service that will be processing the logs that needs them in json format?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enables custom flask log formatting. Added example omm_config with json formatting for reference
Test Plan
To test, replace
OMM_CONFIG: /build/reference_omm_configs/development_omm_config.pywith
OMM_CONFIG: /build/reference_omm_configs/json_log_omm_config.pyin
docker-compose.yaml, then start the app. It should then log in json format after startup.