Fix header search paths while archiving #100
Conversation
It is no longer needed with the custom copy headers phase as cited in: https://developer.apple.com/library/ios/technotes/iOSStaticLibraries/Articles/creating.html#//apple_ref/doc/uid/TP40012554-CH2-SW4 > The include folder inside a build products directory is in the default header search path for applications, so this is an appropriate place to put header files.
|
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks! |
|
Interesting! Didn't know about that. The change looks good, but the Travis build is failing. It looks like it's missing a code signing identity, so you might need to turn off code signing for the archive build there? |
See the "SIGNING IDENTITIES" section in the manual entry for `codesign(1)` for details. This allows us to sign without a signing identity on CI.
|
Ok I think I found the right incantation @grp. I'm just waiting on my company to take a look at the CLA. Let me know if there's anything else! |
sharplet
force-pushed
the
archive-header-search-paths
branch
from
10ff93c
to
4e555a8
Compare
|
@grp Just signed the CLA, let me know if there's anything else! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
Fix header search paths while archiving
|
Thanks! |
There's a portion of Apple's "Using Static Libraries in iOS" guide that describes this problem with the "Headers" build phase when using static libraries (emphasis added):
When trying to integrate Tweaks into our workspace, we found the same issue: archiving our app was broken.
We've updated FBTweak.xcodeproj to use a custom "Copy Files" build phase that places the public headers into
include/FBTweak/, relative to the built products directory. This location is automatically added to the header search paths by Xcode, and thus it is no longer necessary to add$(SYMROOT)/Headersto the header search paths when building Tweaks from a workspace.To test this, we've updated
.travis.ymlto perform an archive action in addition to running the tests.