New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Features should be additive, don't use nostd feature, but use an std one instead #377

Open

kevinlewi opened this issue Jun 10, 2023 · 1 comment

Labels

cleanup

Contributor

kevinlewi commented Jun 10, 2023

Based on https://doc.rust-lang.org/cargo/reference/features.html?highlight=additive#feature-unification

We should replace our nostd feature to instead have an std feature that enables std.

kevinlewi added the cleanup label

Contributor Author

kevinlewi commented Jun 19, 2023

One example of where this should be addressed: https://github.com/facebook/akd/blob/main/akd_core/src/lib.rs#L182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment