Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating VRF encode_to_curve checks #401

Merged
merged 1 commit into from Sep 21, 2023
Merged

Updating VRF encode_to_curve checks #401

merged 1 commit into from Sep 21, 2023

Conversation

kevinlewi
Copy link
Contributor

  • Renames hash_to_curve to encode_to_curve
  • Checks for identity point before returning encode_to_curve output
  • Also checks for point being >= p
  • Updates VRF draft references to point to RFC9381

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Sep 2, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 2, 2023 •
edited

Codecov Report

Patch coverage: 84.00% and project coverage change: -0.05% ⚠️

Comparison is base (5c2bc73) 87.77% compared to head (78a5fd5) 87.72%.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #401      +/-   ##
==========================================
- Coverage   87.77%   87.72%   -0.05%     
==========================================
  Files          39       39              
  Lines        8771     8785      +14     
==========================================
+ Hits         7699     7707       +8     
- Misses       1072     1078       +6
Files Changed Coverage Δ
akd_core/src/ecvrf/mod.rs 38.46% <ø> (ø)
akd_core/src/ecvrf/ecvrf_impl.rs 90.71% <83.33%> (-1.22%) ⬇️
akd_core/src/ecvrf/tests.rs 96.12% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kevinlewi
Copy link
Contributor Author

kevinlewi commented Sep 3, 2023 •
edited

Clippy errors got fixed in #401 and should disappear after rebasing on top of that PR

Edit: Nevermind, will be fixed in #402

@kevinlewi kevinlewi marked this pull request as ready for review September 3, 2023 21:57
slawlor
slawlor approved these changes Sep 5, 2023
View reviewed changes
Copy link
Contributor

@slawlor slawlor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple nits, but looks good!

akd_core/src/ecvrf/ecvrf_impl.rs Outdated Show resolved Hide resolved
akd_core/src/ecvrf/ecvrf_impl.rs Show resolved Hide resolved
@kevinlewi kevinlewi linked an issue Sep 6, 2023 that may be closed by this pull request
VRF draft update to RFC 9381 plus fixes #397
Closed
@kevinlewi kevinlewi merged commit 9f6646e into facebook:main Sep 21, 2023
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slawlor slawlor slawlor approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

VRF draft update to RFC 9381 plus fixes
4 participants
@kevinlewi @codecov-commenter @slawlor @facebook-github-bot