New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
file paths with whitespace cause rev parsing to fail with hg #52
Comments
This is a dupe of facebook/grocery-delivery#22 Which... ya know people should not do that, which is why we marked it wishlist. Bad engineers, bad. |
@jaymzh is GD handling this more gracefully somehow? for me taste-tester is completely stuck until you dump everything and re upload on a revision that's ahead of the "bad entry" |
No, gd will get fucked to, we're just smart enough to not put spaces in filenames, cause that's insane. On September 2, 2016 2:10:09 PM PDT, Joshua Miller notifications@github.com wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
"we" is a pretty strong word. |
I give you permission to verbally smack down people putting spaces in filenames in our chef repo ;) |
@jaymzh how lenient are chef-zero and chef-server about what one can put in the path? tt/gd should match exactly that, and leave in user's discretion to narrow it down. I like my ☃ |
@odcinek they allow it primarily because they work on windows. WHich is why I didn't close this as |
Got bit for this again today. Turns out "we" aren't smart. |
Fixed with #111 |
When parsing a hg revision to extract the changes, parse_status(changes) will try to regex the hg log output with something like 'when /^A (\S+)$/' , but if the path has whitespace in it, it will fail to match the regex and fail the call. This might be a problem with the other repo types (git, svn) as well.
Sample:
A ../../some/path/to/a/file/abcd stuffafteraspace
Maybe it's safe to assume chef repo contents won't have spaces in them, but the repo in play could have all kinds of other crap; maybe it should filter out said crap prior to mapping?
The text was updated successfully, but these errors were encountered: