Skip to content
This repository has been archived by the owner on Nov 10, 2023. It is now read-only.

buck test -e no longer means exclude #42

Closed
spearce opened this issue Jul 26, 2013 · 3 comments
Closed

buck test -e no longer means exclude #42

spearce opened this issue Jul 26, 2013 · 3 comments

Comments

@spearce
Copy link
Contributor

spearce commented Jul 26, 2013

In c14981b Simon changed -e to mean --emulator instead of --exclude. This was a surprising behavior change. :-(

@shs96c
Copy link
Contributor

shs96c commented Jul 29, 2013

Sorry about that. We decided to go with the naming convention of adb for identifying which device to target when running tests since we had a clash with "-e" between the (un)install commands and the running test one. If you can think of a better short-name to use for "exclude", I'd be happy to add something back.

If not, is there anything to be done for this issue? I'm not sure if you're requesting us to change it back or just informing us that we should be better at announcing changes (or both)

@spearce
Copy link
Contributor Author

spearce commented Jul 29, 2013

It would be nice if options don't change behavior, and if they do if its better communicated. But I understand you don't want to change it back so we are stuck with --exclude.

@shs96c
Copy link
Contributor

shs96c commented Aug 1, 2013

It's a good point about the communication of changes, particularly of our UI. Thanks for bringing it up. @bolinfest, perhaps we should start keeping some sort of changelog?

@shs96c shs96c closed this as completed Aug 1, 2013
cwoodwar6 pushed a commit to cwoodwar6/buck that referenced this issue Jul 23, 2018
…o-generated-sources to master

* commit 'a833b303dcc55692037441ce979402e579abfb36':
  Don't add generated code to javac sources if we aren't generating code.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants