latest

Expose a staticlib subtarget for rust libraries

Summary:
Adds a `foo[staticlib]` subtarget to rust libraries, and uses it in `libclank`'s `staticlib_extractor`.

Ideally, the way that staticlib_extractor works to embed rust code into make requires a number of assumptions to hold, and we should try to fix this. The way zephyr_module works by gathering the link infos and exposing them as link args to cmake would be much nicer (https://www.internalfb.com/code/fbsource/[3616616e6817]/arvr/firmware/ar/zephyr/build_defs/zephyr_v2.bzl?lines=392-415)

Reviewed By: shayne-fletcher

Differential Revision: D57167468

fbshipit-source-id: 2bbbdbcfe86ef09c65a7a9a036dd2d68cd9f4a81

2024-05-01

Prefer pub(crate) for visibility

Summary:
`pub(crate)` generally gives better 'unused definition' warnings from rustc, because it knows the definition isn't used elsewhere.

Use `pub(crate)` wherever we can, and fix definitions that didn't need to be `pub` or `pub(crate)`.

Reviewed By: samkevich

Differential Revision: D56778389

fbshipit-source-id: b73364f96e9601e94a1196b25f78e92968a3edb0

2024-04-15

Simplify select tests

Summary: Pass resolved select keys to `select_the_most_specific` instead of passing `ResolvedConfigurationSettings` which contains incompatible keys too.

Reviewed By: JakobDegen

Differential Revision: D56121980

fbshipit-source-id: 1d278c1a746a6fac92303f20a2cbc05a37730a79

2024-04-01

cells: Repro broken cell handling in file watcher

Summary: Explanation in the diff. This seems pretty bad, I'm not going to fix it though, because it's kind of hard.

Reviewed By: stepancheg

Differential Revision: D55573384

fbshipit-source-id: b7b4483fcf34179bdeb18e33713ab7ce9422e857

2024-03-15

buck2: glossary: snake casing nit

Summary: ^

Reviewed By: JakobDegen

Differential Revision: D54929757

fbshipit-source-id: 12bc297b977c82062bdce9d5c41c6ff5b6b6a870

2024-03-01

Pass correct rpath origin setting to linker on Darwin for Haskell (#567)

Summary:
This is a follow-up to https://github.com/facebook/buck2/issues/536 which fixes a problem on Darwin when trying to execute a haskell_binary fails with:

```
dyld[13654]: Library not loaded: rpath/lib_backend.dylib
  Referenced from: <no uuid> /Users/runner/work/buck-out/v2/gen/root/6e975d09ae66fe71/backend/one-off-task/__one-off-task__/one-off-task
  Reason: tried: '$ORIGIN/__one-off-task__shared_libs_symlink_tree/lib_backend.dylib' (no such file), '$ORIGIN/__one-off-task__shared_libs_symlink_tree/lib_backend.dylib' (no such file), '/usr/local/lib/lib_backend.dylib' (no such file), '/usr/lib/lib_backend.dylib' (no such file, not in dyld cache)
```

Pull Request resolved: https://github.com/facebook/buck2/pull/567

Reviewed By: simonmar

Differential Revision: D54346421

Pulled By: JakobDegen

fbshipit-source-id: 00d5d9fd44fb52b24f80bfecdf0cf3683b1e44b1

2024-02-15

Support GODEBUG env-var

Summary: Support setting [GODEBUG](https://go.dev/doc/godebug) on toolchain level

Reviewed By: leoleovich

Differential Revision: D53769175

fbshipit-source-id: 5a685f74ff9ad44a22f7fe2271a232697836132f

2024-02-01

Fix union return type in buck2 cfg

Summary: https://fburl.com/workplace/o4ae6dwy

Reviewed By: apolloww

Differential Revision: D53290572

fbshipit-source-id: 53bdd7017842edfc911074e49fa310f07cbad56b

2024-01-15

rules: Reimplement native unbundled deps to better support `FORCE_RLI…

…B`: Take 3

Summary: Reland of D52749222 , the only thing that has changed is that D52719606 is squashed in

Reviewed By: dtolnay

Differential Revision: D52771691

fbshipit-source-id: 40054a8ee634bbc753e2c57637ecc8df87181915

2024-01-02

Back out "Move e2e under meta_only"

Summary:
Original commit changeset: 2e0ffb40ab38

Original Phabricator Diff: D52293327

This is making lots of buck2 tests flaky/broken
https://fburl.com/omh/6dqojh2j

Reviewed By: zertosh

Differential Revision: D52397329

fbshipit-source-id: 823ab22b059008f27862bdfcef2bcabe87b3c128