New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failures on OSS platform #63
Comments
Here's contents of dockerfile that we use to build containers to reproduce the mentioned failures: RUN dnf install -y COPY contrib/prerequisites-centos8.sh prerequisites-centos8.sh Docker run command:
|
@vicvicg - thanks, I'm working on reproducing it locally. Does your docker environment enforces any additional restrictions (e.g. seccomp, apparmor, or similar) ? |
Hi! We found a problem in NvmCacheTests.ConcurrentFills that under a certain race condition it fails. We will be working on fixing this. |
Summary: When an item is insertOrReplaced into hybrid cache, a nvm.remove is scheduled. If the remove is still in flight (not completed) when the same item is evicted from RAM, the nvm.put from DRAM eviction could get aborted. This diff changes the unit test to account for this case. We anticipate this solves a problem mentioned in #150 and #63. Reviewed By: therealgymmy Differential Revision: D37807056 fbshipit-source-id: ba27a31eb418b41b0e3223d1644830e38970387d
@vicvicg Do you still see test failures in the built? |
Discussed in #61
Originally posted by vicvicg October 11, 2021
When running CacheLib tests following the instructions (https://cachelib.org/docs/installation/testing), we get different test pass rates depending on the environment, some test failures seem to be intermittent, and we haven’t seen 100% pass rate. Is there a recommended system set up and subset of tests that we can use as an acceptance criteria for code changes?
NvmCacheTests.ConcurrentFills failure :
Timer tests failure: This seems like a poorly written test that does not account for timing in code with sleep
The text was updated successfully, but these errors were encountered: