Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no resetToHandle found. #65

Closed
zzerroo opened this issue Oct 14, 2021 · 4 comments
Closed

no resetToHandle found. #65

zzerroo opened this issue Oct 14, 2021 · 4 comments
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@zzerroo
Copy link
Contributor

zzerroo commented Oct 14, 2021

Summary of Issue or Feature request

the function resetToItemHandle in FixedSizeArray.h calls resetToHandle, but there is no such function in this project。Should it be resetToItemHandle (in TypedHandle.h) ？

Goal

Should it be resetToItemHandle (in TypedHandle.h) ？

Context

Suggested Approach

Success Metrics
@sathyaphoenix
Copy link
Contributor

@zzerroo you are right! Do you mind sending out a PR to fix this. Also, could you share some context on how you plan to use the FixedSizeArray.

@sathyaphoenix sathyaphoenix added bug Something isn't working good first issue Good for newcomers labels Oct 14, 2021
@sathyaphoenix
Copy link
Contributor

@zzerroo the code has been broken this way when TypedHandle.h was refactored in 2018 :) Looks like there is no usage of this function in our unit tests for FixedSizeArray and we didn't notice the build failure.

@zzerroo
Copy link
Contributor Author

zzerroo commented Oct 15, 2021

ok, i will send out a pr later. currently we are just doing some simple encapsulation.

@sathyaphoenix sathyaphoenix linked a pull request Oct 18, 2021 that will close this issue
bugfix-change resetToHandle to resetToItemHandle for issues#65 #66
Closed
@sathyaphoenix
Copy link
Contributor

This is now fixed. Thanks @zzerroo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bugfix-change resetToHandle to resetToItemHandle for issues#65 zzerroo/CacheLib
2 participants
@sathyaphoenix @zzerroo