Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI failures #180

Closed
scottruss opened this issue Oct 14, 2021 · 2 comments
Closed

Fix CI failures #180

scottruss opened this issue Oct 14, 2021 · 2 comments
Assignees
@scottruss

Comments

@scottruss
Copy link
Contributor

scottruss commented Oct 14, 2021 •
edited

several shellcheck failures for fb_network_scripts/files/default/ifup-pre-local

kitchen failures for unknown instance:

  • /usr/bin/kitchen test default-debian-10
  • /usr/bin/kitchen test default-ubuntu-2004
  • /usr/bin/kitchen test default-centos-8

kitchen failures for grub:

template[grub2_config_efi] action create
Parent directory /boot/efi/EFI/debian does not exist.

various rubocop failures
@scottruss scottruss self-assigned this Oct 14, 2021
@jaymzh
Copy link
Collaborator

jaymzh commented Oct 14, 2021 •
edited

@scottruss see #175 , #176 , and #177 - I have fixes for several of these.

@scottruss
Copy link
Contributor Author

The basics of the CI failures (images, rubocop, foodcritic, shellcheck) have been addressed, the remaining are actual failures in cookbooks. I'm going to close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@scottruss scottruss

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jaymzh @scottruss