fb_network_scripts: start making gated_template tests pass #177
Conversation
|
cc @anitazha who is refactoring this logic for networkd |
|
Yea I'm working on moving this to fb_helpers so I can reuse it for fb_networkd. Do you mean just the github tests? It does appear to pass if I do use fb_chefspec on the commandline. |
|
In this case the tests don't pass on GH because - at least in part - they run in a container which doesn't pull in the systemd stuff which then lets all the rest of this crap break. |
|
@scottruss has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator. |
|
@scottruss still necessary to fix the tests. Are you asking for a rebase, or are you saying you're gonna add that and I should drop this? |
They don't pass yet, but this gets them a lot closer. I mostly made this for @davide125 to take over and finish. Signed-off-by: Phil Dibowitz <phil@ipom.com>
jaymzh
force-pushed
the
gated_tempalte
branch
from
19929ef
to
6288bfe
Compare
|
@jaymzh has updated the pull request. You must reimport the pull request before landing. |
|
@scottruss rebased. |
|
@davide125 has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
| # on the execute[load modules] resource in systemd | ||
| include_recipe 'fb_systemd' | ||
| include_recipe 'fb_modprobe' | ||
| include_recipe 'fb_network_scripts' |
There was a problem hiding this comment.
Pulling in a bunch of largely unrelated recipes (and their dependencies) will make this horribly brittle, and make the deps explode for fb_helpers.
Backing up - what's actually breaking here? I can't infer what systemd has to do with this spec. And I'm failing to find the original error which is showing up in GH
There was a problem hiding this comment.
Well the fb_systemd is for:
expected Chef::Exceptions::UserIDNotFound, got #<NoMethodError: undefined method `fb_systemd_reload' for cookbook: fb_systemd, recipe: reload :Chef::Recipe> with backtrace:
Then, per the comments, once you load fb_systemd, then it want modprobe.
Not sure I remember what network_scripts was for, but my guess is another error popped up after that.
There was a problem hiding this comment.
Looks like whatever the dep was is gone. will close.
They don't pass yet, but this gets them a lot closer. I mostly
made this for @davide125 to take over and finish.