fb_systemd: use to_ini in systemd configs cleanup #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh hey look you even have an intern diff for it. =P |
|
Yes -- this isn't merged yet because it triggers a foodcritic bug, so we left it open as a repro. @NaomiReeves was going to followup with upstream (details are in the internal task for this PR). |
Summary: Pull Request resolved: facebook#54 Clean up as the rollout is now complete. Reviewed By: joshuamiller01 Differential Revision: D14283402 fbshipit-source-id: 8c1f03a6a089ce6479149af557bc806703237ce5
davide125
force-pushed
the
export-D14283402
branch
from
02ba228
to
aebce28
Compare
|
This pull request has been merged in 4575c0f. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Clean up as the rollout is now complete.
Reviewed By: joshuamiller01
Differential Revision: D14283402